Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- Added product remove from stock after success pay. #103

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

- Added product remove from stock after success pay. #103

wants to merge 2 commits into from

Conversation

Pablets
Copy link

@Pablets Pablets commented Feb 4, 2021

Issue #102 fix

  • Added Public / protected route to update only product stock after purchase.
  • Added "productUpdateStockReducer" for this specific purpose.
  • Fixed Product list not updating after purchase.
  • Deleted CART_CLEAR_ITEMS completely in order to correctly update the stock from each of the products (in case they are more than 1 in the same cart it works to)

- Added Public / protected route to update only product stock after purchase.
- Fixed Product list not updating after purchase.
- Deleted CART_CLEAR_ITEMS completely in order to correctly update the stock from each of the products (in case they are more than 1 in the same cart.)
@basir
Copy link
Collaborator

basir commented Feb 6, 2021

your code format is not aligned with the repo. you have used a semicolon at the end of each command. fix this issue and send a new commit.

@Pablets
Copy link
Author

Pablets commented Feb 7, 2021

Fixed @basir. Sorry, for the obvious mistake. Hope you find it useful!

@agt-ru
Copy link

agt-ru commented Feb 18, 2021

@Pablets I tried to implement your fix, but found it insecure.
This way every user can send a PUT request to the server
and arbitrarily change any product's count in stock using token and the product id.

@Pablets
Copy link
Author

Pablets commented Feb 21, 2021

@agt-ru Thanks for the advice, I'll try to fix it as soon as possible.

@aashiqahmed98
Copy link

aashiqahmed98 commented Feb 27, 2021

@Pablets , did you finished working on the security thing?

@Pablets
Copy link
Author

Pablets commented Feb 27, 2021

@aashiqahmed98 No, I thougth in a solution but didn't have time to implement it yet. The route need to be avalaible only when certain conditions are meet in order to be secure. It needs some state modeling before do anything.

@talmax1124
Copy link

@Pablets Can you help me out to integrate stripe?

@talmax1124
Copy link

@Pablets Can you help me integrate a feature? I'm new to react, and need help integrating this

@sujankarki269
Copy link

@Pablets did you finished implementation on the security thing?

@talmax1124
Copy link

@Pablets Did you find a way to allow to add more qty to the same product from product screen

@talmax1124
Copy link

@Pablets I can't get this to work. Can you send me a PR?

@talmax1124
Copy link

Fixed @basir. Sorry, for the obvious mistake. Hope you find it useful!

@Pablets I can't add it to my repo. It is giving me errors. Can you help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants